Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent allocation from encoding UDP address #684

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Prevent allocation from encoding UDP address #684

merged 1 commit into from
Apr 20, 2024

Conversation

paulwe
Copy link
Contributor

@paulwe paulwe commented Apr 20, 2024

No description provided.

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 79.14%. Comparing base (75092df) to head (757e240).

Files Patch % Lines
udp_muxed_conn.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   79.06%   79.14%   +0.07%     
==========================================
  Files          41       41              
  Lines        3741     3745       +4     
==========================================
+ Hits         2958     2964       +6     
+ Misses        549      548       -1     
+ Partials      234      233       -1     
Flag Coverage Δ
go 79.14% <83.33%> (+0.07%) ⬆️
wasm 22.09% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

how do the benchmarks compare before & after?

@paulwe
Copy link
Contributor Author

paulwe commented Apr 20, 2024

45ns vs 16ns but it saves 2 allocations per packet

@paulwe paulwe force-pushed the encode-udp branch 2 times, most recently from 1afacca to 68431a6 Compare April 20, 2024 04:15
@paulwe paulwe merged commit 82b41d9 into master Apr 20, 2024
15 checks passed
@paulwe paulwe deleted the encode-udp branch April 20, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants