Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection close log #605

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix connection close log #605

merged 1 commit into from
Aug 7, 2023

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Aug 7, 2023

Printf arguments weren't passed to the logger.

Printf arguments weren't passed to the logger.
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (21d18f5) 78.45% compared to head (7fa595a) 78.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #605      +/-   ##
==========================================
+ Coverage   78.45%   78.50%   +0.04%     
==========================================
  Files          42       42              
  Lines        4387     4387              
==========================================
+ Hits         3442     3444       +2     
+ Misses        730      727       -3     
- Partials      215      216       +1     
Flag Coverage Δ
go 78.50% <100.00%> (+0.04%) ⬆️
wasm 22.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
gather.go 66.78% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat at-wat merged commit efff4c4 into master Aug 7, 2023
16 checks passed
@at-wat at-wat deleted the fix-conn-close-log branch August 7, 2023 06:11
@at-wat at-wat mentioned this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants