Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clear selected pair on ICE failed (#612)
When ICE times out and fails, all candidates are deleted. That means all the candidates are closed and their underlying conns are clsoed. But, the selected pair could still be valid. On a subsequenct `Write`, ICE transport conn will get the selected pair and write to the pair. As the pair is still valid, write will flow through to the local candidate `writeTo`. But, as all candidates and their underlying conns are closed, `Write` will return a `io.ErrClosedPipe` error. There are cases where it is not ignored and causes a broken pipe after an ICERestart. When the `Write` error propagates back to sctp/association, the writeLoop is exited. So, sending data channel traffic after a successful ICERestart still fails as the SCTP association errored out and write loop exited. I have copied the changes that are done when ICERestart happens to when ICE state is set to failed (except for gathering state and resetting ufrag/pwd). In my testing, it is working well, i. e. can continue data channel after ICE Restart whereas previously it was failing every time. But, I am not sure of all the implications of this change. Update authors Update AUTHORS.txt
- Loading branch information