Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Modify user settings for editor to enable query suggestions #1485

Merged
merged 5 commits into from
Aug 19, 2024
Merged

ui: Modify user settings for editor to enable query suggestions #1485

merged 5 commits into from
Aug 19, 2024

Conversation

zhangvi7
Copy link
Contributor

@zhangvi7 zhangvi7 commented Aug 9, 2024

Context

  • Hide query suggestion feature toggle behind ‘User Settings’ value to allow users to control enablement
  • Next PR will handle creating widget to display suggestions in the code editor when typing

Test Plan

image

@zhangvi7 zhangvi7 merged commit e9fe05b into pinterest:coding-assistant Aug 19, 2024
3 checks passed
@zhangvi7 zhangvi7 deleted the user-setting branch August 19, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

@jczhong84 jczhong84 Awaiting requested review from jczhong84

@kgopal492 kgopal492 Awaiting requested review from kgopal492

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangvi7 @czgu