Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement developer assistance query rewriting #1298

Closed
wants to merge 3 commits into from
Closed

Implement developer assistance query rewriting #1298

wants to merge 3 commits into from

Conversation

adamobeng
Copy link

  • Add query diffs to QueryValidationResult output which is passed to frontend
  • Add validator which combines other validators, so that more than one validator can be called
  • Add optimizing validator which suggests improvements
  • Implement fixes for UNION, multiple LIKEs and COUNT(DISTINCT

aobeng added 3 commits July 1, 2023 00:20
Add query diffs to QueryValidationResult
f2c77a2 
Test:
	$ docker-compose --file containers/docker-compose.test.yml run test bash './querybook/scripts/run_test' --python
        [...]
        265 passed, 454 warnings in 4.04s
Add validator which combines other validators
e0e5ca5 
Testing:

	make test_image && docker-compose --file containers/docker-compose.test.yml run test bash './querybook/scripts/run_test' --python
	[...]
	267 passed, 454 warnings in 4.14s
Add optimizing validator which suggests improvements
ee43220 
- COUNT DISTINCT -> APPROX_DISTINCT
- UNION -> UNION ALL
- Multiple LIKEs -> REGEXP_LIKE

Testing:

	make test_image && docker-compose --file containers/docker-compose.test.yml run test bash './querybook/scripts/run_test' --python
	[...]
	275 passed, 456 warnings in 4.17s
@kgopal492 kgopal492 changed the base branch from master to dev-query-optimization July 25, 2023 19:51
@kgopal492 kgopal492 mentioned this pull request Jul 27, 2023
Merged
@kgopal492 kgopal492 deleted the branch pinterest:dev-query-optimization August 14, 2023 16:51
@kgopal492 kgopal492 closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamobeng @kgopal492