feat: Added datadoc and list access permissions for user groups #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow this is awesome! |
jczhong84
reviewed
Aug 15, 2023
anacltd
reviewed
Feb 6, 2024
…49/querybook into external/group-permissions
Co-authored-by: Ana <[email protected]>
…ternal/group-permissions
…49/querybook into external/group-permissions
jczhong84
reviewed
Feb 25, 2024
querybook/webapp/components/BoardViewersList/BoardViewersList.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/DataDocViewersList/DataDocViewersList.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the already implemented user groups and expands them so that they actually grant permissions to their members. These user groups can be assigned as editors for datadocs or lists, and can have read or write privileges. Groups can also be members of other groups, and therefore groups can also inherit permissions from other groups which they will then pass on to their members.
In addition, a user will always have the access level of its most permissive permission. For example, if a user is directly added to a datadoc with read-only permissions but is also a member of a group with edit permissions, the user will have edit permissions until the group is removed or the group permissions revoked.