Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no early return in loadTransportStreamBuilder #2014

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

viceice
Copy link
Contributor

@viceice viceice commented Jul 24, 2024

Don't return early in loadTransportStreamBuilder, it'll return undefined instead if the expected function.
I'll also fixed the type annotation to be a promise. 😉

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from jsumners July 24, 2024 10:28
@viceice
Copy link
Contributor Author

viceice commented Jul 24, 2024

🤔 the failed test is unrelated to my changes 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: "fn is not a function" while setting up a pino transports since v9.2.1
3 participants