Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomod(dm): upgrade go-mysql to 1.9.1 #11630

Merged
merged 2 commits into from
Sep 30, 2024
Merged

gomod(dm): upgrade go-mysql to 1.9.1 #11630

merged 2 commits into from
Sep 30, 2024
+4 −5

Conversation

fishiu
Copy link
Contributor

@fishiu fishiu commented Sep 26, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11603

What is changed and how it works?

update github.com/go-mysql-org/go-mysql version from 1.7.1 to 1.9.1, which support connecting to mysql 8.0 with password longer than 19 characters.

Check List

Tests

  • Unit test
  • Manual test

Manual test: run quick-start dm task and saw no more connection error.

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 26, 2024
@sre-bot
Copy link

sre-bot commented Sep 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 26, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

Welcome @fishiu!

It looks like this is your first PR to pingcap/tiflow 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tiflow. 😃

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

Hi @fishiu. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2024
@Benjamin2037
Copy link
Contributor

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Sep 26, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 26, 2024
Benjamin2037
Benjamin2037 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-26 07:52:19.627118927 +0000 UTC m=+1725209.367542864: ☑️ agreed by lance6716.
  • 2024-09-26 07:58:00.320672446 +0000 UTC m=+1725550.061096384: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the area/dm Issues or PRs related to DM. label Sep 26, 2024
@fishiu
Copy link
Contributor Author

fishiu commented Sep 26, 2024

/retest

@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.4149%. Comparing base (4e177d9) to head (a8f96ab).
Report is 2 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.0338% <ø> (-0.0159%) ⬇️
dm 51.0967% <ø> (+0.0262%) ⬆️
engine 63.4232% <ø> (+0.0353%) ⬆️
Flag Coverage Δ
unit 57.4149% <ø> (+0.0063%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11630        +/-   ##
================================================
+ Coverage   57.4086%   57.4149%   +0.0063%     
================================================
  Files           852        852                
  Lines        126845     126845                
================================================
+ Hits          72820      72828         +8     
+ Misses        48627      48620         -7     
+ Partials       5398       5397         -1

@fishiu
Copy link
Contributor Author

fishiu commented Sep 26, 2024

/retest

5 similar comments
@fishiu
Copy link
Contributor Author

fishiu commented Sep 26, 2024

/retest

@lance6716
Copy link
Contributor

/retest

@fishiu
Copy link
Contributor Author

fishiu commented Sep 26, 2024

/retest

@fishiu
Copy link
Contributor Author

fishiu commented Sep 27, 2024

/retest

@fishiu
Copy link
Contributor Author

fishiu commented Sep 27, 2024

/retest

@fishiu
Copy link
Contributor Author

fishiu commented Sep 27, 2024

/retest

4 similar comments
@fishiu
Copy link
Contributor Author

fishiu commented Sep 27, 2024

/retest

@fishiu
Copy link
Contributor Author

fishiu commented Sep 29, 2024

/retest

@lance6716
Copy link
Contributor

/retest

@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit dec7d0e into pingcap:master Sep 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't connect to mysql server 8.0 when password is larger than 19 characters
4 participants
@fishiu @sre-bot @Benjamin2037 @lance6716