Do not accept wrong dates (e.g. 2080) #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I experienced multiple times a glitch in ntp sync that resulted in setting the date to year 2080. This is a quick dirty fix to mitigate the issue and let the system run the sync again
oddstr13
suggested changes
May 11, 2024
There was a problem hiding this comment.
It would be better to figure out why you are getting an unexpected date from ntp than hardcoding it here now.
In 26 years, it will be a problem for everyone if this is merged.
Hardcoding a lower limit is OK, as we are querying for the current datetime, and 2020 should hopefully never happen again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced multiple times a glitch in ntp sync that resulted in setting the date to year 2080. This is a quick dirty fix to mitigate the issue and let the system run the sync again