815 reference checker should handled the input files the same for the check dir than the check project #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 2, 2024 23:38
…Collector look in sharing visitedFile for didn't repass the same file
…the files in the visitor result with a includesAll:
Ducasse
reviewed
Oct 18, 2024
| @@ -72,8 +72,21 @@ MicReferenceChecker >> addDuplicatedFirstAnchor: anAnchor [ | |||
| { #category : 'main API' } | |||
| MicReferenceChecker >> checkDirectory: aDir [ | |||
| "Take the directory, parse all its children with microdown file parser and let the visitor visit each time then return visitor is ok which should be true if every thing is okay, the visitor turned out to treat the many documents that it visits as one, so if anchor is duplicated in another file it will detect that . " | |||
|
|
|||
| self checkList: aDir allFiles | |||
There was a problem hiding this comment.
I asked myself why we do not call checkList:
Another question I asked my self was why the collector is not shared between the checkDirectory: and checkProject:
There was a problem hiding this comment.
Here I reused the checkProject: code for having the same semantic in both of checkProject and checkDirectory. chekList: is call at the end of the method.
For the collector who aren't shared between the checkDirectory: and checkProject:, I didn't think about it, maybe I can create a collector variable for the class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #815
I change checkDirectory for using the same semantic as CheckProject
I also change visitRoot: of MicFileCollector for didn't visit a file already visited in the directory