Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceChecker should handled the inputFiles the same for the checkDir: than the checkProject:. #815

Open
Ducasse opened this issue Aug 3, 2024 · 3 comments
Assignees

Comments

@Ducasse
Copy link
Contributor

Ducasse commented Aug 3, 2024

Right now

  • checkProject: is looking for the transitive closure of the files via inputFile (using the fileCollector)
  • checkDirectory: does not look for the transitive closure and this is not good.

both checkProject: and checkDirectory: should have the same semantics.

We should add a test clearly showing that they is not difference once this problem is fixed.

@Ducasse
Copy link
Contributor Author

Ducasse commented Aug 3, 2024

@melkiyasser

@Ducasse
Copy link
Contributor Author

Ducasse commented Sep 5, 2024

checkProject: is basically looking for all the files it can reach starting from an input. When making checkDir: using the same logic with all the files in a directory, the worklist should be shared among all the files in checkDir: to avoid to treat files multiple times (it could happens if we have several files in the directory pointing a same inputFile for example).

@Ducasse
Copy link
Contributor Author

Ducasse commented Oct 17, 2024

We should check the PR of Quentin because I have some doubts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants