windon replaces wind in reporting (still compatible with wind) #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lecfab
force-pushed
the
windOffshore
branch
from
25be3f1
to
febb9dd
Compare
lecfab
requested review from
LaviniaBaumstark and
cchrisgong
and removed request for
cchrisgong and
fschreyer
14 tasks
cchrisgong
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because wind is going to be renamed windon throughout remind, this PR allows for the two possibilities in reporting. It also deletes the very old situation where windoff didn't exist.
Note that many lines are updated only because of style formatting (
make format).