-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pcc from remind2 reporting to fix summation checks #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
orichters
requested review from
LaviniaBaumstark and
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
September 6, 2023 14:44
why was it not 0 in reportSE so that it could break the summationCheck? |
Because it is not zero, probably because we did not operate it out of the input data:
|
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
approved these changes
Sep 7, 2023
But |
LaviniaBaumstark
approved these changes
Sep 7, 2023
This was referenced Sep 7, 2023
remove 'Electricity|Coal|Pulverised Coal w/ CC' from mandatory variables
pik-piam/piamInterfaces#163
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcc
is an "outdated technology" not covered by REMIND anymoreSE|Electricity|Coal|++|Pulverised Coal w/ CC (EJ/yr)
pe2se$all_te
anymore and was therefore not added toSE|Electricity|+|Coal
So let us kill it.