Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pcc from remind2 reporting to fix summation checks #453

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Sep 6, 2023

SE|Electricity|+|Coal <
   + SE|Electricity|Coal|++|Gasification Combined Cycle w/o CC
   + SE|Electricity|Coal|++|Gasification Combined Cycle w/ CC
   + SE|Electricity|Coal|++|Pulverised Coal w/o CC
   + SE|Electricity|Coal|++|Pulverised Coal w/ CC
   + SE|Electricity|Coal|++|Combined Heat and Power w/o CC
   + SE|Electricity|Coal|++|Other
Relative difference between -321.83% and -0.00000608%, absolute difference up to 0.0000375 EJ/yr.

So let us kill it.

@orichters orichters linked an issue Sep 6, 2023 that may be closed by this pull request
2 tasks
@LaviniaBaumstark
Copy link
Member

why was it not 0 in reportSE so that it could break the summationCheck?

@orichters
Copy link
Contributor Author

Because it is not zero, probably because we did not operate it out of the input data:

> output <- remind2::reportSE("output/testOneRegi/fulldata.gdx")
> output[,,"SE|Electricity|Coal|++|Pulverised Coal w/ CC (EJ/yr)"]
An object of class "magpie"
, , d3 = SE|Electricity|Coal|++|Pulverised Coal w/ CC (EJ/yr)

        tall
all_regi y2005 y2010 y2015        y2020        y2025        y2030        y2035
     LAM     0     0     0 1.104074e-06 2.207520e-06 2.207520e-06 2.207520e-06
     OAS     0     0     0 0.000000e+00 0.000000e+00 0.000000e+00 2.207520e-06
     SSA     0     0     0 0.000000e+00 0.000000e+00 0.000000e+00 2.207520e-06
     EUR     0     0     0 1.091369e-06 2.207520e-06 2.227425e-06 2.207520e-06
     NEU     0     0     0 1.104074e-06 2.207520e-06 2.207520e-06 2.207520e-06
     MEA     0     0     0 1.101305e-06 2.207520e-06 2.207520e-06 2.207520e-06
     REF     0     0     0 0.000000e+00 0.000000e+00 2.207520e-06 4.413783e-06
     CAZ     0     0     0 1.104074e-06 2.207520e-06 2.207520e-06 2.207520e-06
     CHA     0     0     0 1.091369e-06 2.207520e-06 2.227425e-06 2.207520e-06
     IND     0     0     0 0.000000e+00 0.000000e+00 0.000000e+00 2.207520e-06
     JPN     0     0     0 0.000000e+00 0.000000e+00 2.207520e-06 4.413783e-06
     USA     0     0     0 1.101305e-06 2.207520e-06 2.207520e-06 2.207520e-06
     GLO     0     0     0 7.697570e-06 1.545264e-05 1.990749e-05 3.090277e-05
        tall
all_regi        y2040        y2045        y2050        y2055        y2060
     LAM 2.207520e-06 2.207520e-06 2.207520e-06 2.207520e-06 2.257446e-06
     OAS 4.413783e-06 4.402688e-06 4.362685e-06 4.264102e-06 4.066675e-06
     SSA 4.413783e-06 4.402688e-06 4.362685e-06 4.264102e-06 4.066675e-06
     EUR 2.207520e-06 2.207520e-06 2.285854e-06 2.207520e-06 2.325311e-06
     NEU 2.207520e-06 2.207520e-06 2.207520e-06 2.207520e-06 2.437916e-06
     MEA 2.207520e-06 2.207520e-06 2.207520e-06 2.207520e-06 2.261251e-06
     REF 4.402688e-06 4.362685e-06 4.264102e-06 4.066675e-06 3.719543e-06
     CAZ 2.207520e-06 2.207520e-06 2.244210e-06 2.207520e-06 2.207520e-06
     CHA 2.207520e-06 2.207520e-06 2.207520e-06 2.207520e-06 2.429352e-06
     IND 4.413783e-06 4.402688e-06 4.362685e-06 4.264102e-06 4.066675e-06
     JPN 4.402688e-06 4.362685e-06 4.264102e-06 4.066675e-06 3.719543e-06
     USA 2.207520e-06 2.207520e-06 2.207520e-06 2.207520e-06 2.261251e-06
     GLO 3.749936e-05 3.738607e-05 3.718392e-05 3.637830e-05 3.581916e-05
        tall
all_regi        y2070        y2080        y2090        y2100        y2110 y2130 y2150
     LAM 2.207520e-06 2.597860e-06 2.207520e-06 1.477037e-06 5.673414e-07     0     0
     OAS 3.161249e-06 2.219218e-06 2.207520e-06 2.138032e-06 1.864989e-06     0     0
     SSA 3.161249e-06 2.219218e-06 2.207520e-06 2.138032e-06 1.864989e-06     0     0
     EUR 2.207520e-06 2.339434e-06 2.207520e-06 1.432837e-06 5.013794e-07     0     0
     NEU 2.207520e-06 2.338190e-06 2.207520e-06 1.420094e-06 4.957102e-07     0     0
     MEA 2.207520e-06 2.597883e-06 2.207520e-06 1.476864e-06 5.673442e-07     0     0
     REF 3.392632e-06 2.207520e-06 2.207520e-06 1.938602e-06 1.241563e-06     0     0
     CAZ 2.207520e-06 2.599985e-06 2.207520e-06 1.483262e-06 5.711023e-07     0     0
     CHA 2.207520e-06 2.338573e-06 2.207520e-06 1.420352e-06 4.943639e-07     0     0
     IND 3.161249e-06 2.219218e-06 2.207520e-06 2.138032e-06 1.864989e-06     0     0
     JPN 3.392632e-06 2.207520e-06 2.207520e-06 1.938602e-06 1.241563e-06     0     0
     USA 2.207520e-06 2.597883e-06 2.207520e-06 1.476864e-06 5.673442e-07     0     0
     GLO 3.172165e-05 2.848250e-05 2.649024e-05 2.047861e-05 1.184268e-05     0     0

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

But pcc should be fixed to 0 in REMIND to avoid confusion (and at some point in the future remove it).

@orichters orichters merged commit 14ab823 into pik-piam:master Sep 7, 2023
1 check passed
@orichters orichters deleted the pcc branch October 16, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove pcc and pco from remind2
3 participants