Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix calculation of gross emissions in GHG emissions variables and complete emissions barplots in cs2 summary part #452

Merged
merged 9 commits into from
Sep 12, 2023

Conversation

fschreyer
Copy link
Contributor

This fixes the calculation of gross emissions for GHG variables in analogy to #394, which is necessary for consistent summations with gross variables and CDR variables (gross emissions + CDR = net emissions). Moreover, I added some more explanation to this calculation. I also added some variables to the sectoral gross + CDR barplots in the summary section of cs2. I furthermore checked the summations of those barplots using piamInterfaces::checkSummations and they are now fine for a recent gdx.

Not sure about ongoing processes here, but we as discussed with Simon we might need a redefinition of gross variables if we want to avoid them being negative when synfuels are captured and stored. Maybe discuss this in a dedicated group with people working on emissions/synfuels/CDR at some point.

Copy link
Contributor

@amerfort amerfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Felix for taking care of it! I can only judge the remind2 part and that one looks good. In general I think the explanation of why some gross variables can still turn negative could be improved, as even though I know the issue I had to wrap my head around the sentences for a couple of minutes :)

@fschreyer
Copy link
Contributor Author

I tried to improve the explanation. Thanks!

@fschreyer fschreyer merged commit 16a72e5 into pik-piam:master Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants