-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add is_quitte() #74
add is_quitte() #74
Conversation
|
|
So i assume both helpers are needed in different contexts and should exist alongside? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between
is_quitte
and the oldis.quitte
? https://github.com/pik-piam/quitte/blob/master/R/is.quitte.R
is.quitte()
requires a'quitte'
class attribute, and a bunch of columns to be of typefactor
, both of which are irrelevant for (most)quitte
functions.
In piamInterfaces, we certainly have lots of of functions using levels
that expect them to come as factors, but that is ok as the data goes through as.quitte
before. I don't fully understand why a second "is quitte" function is useful and would probably have preferred something like is.quitte(strict = FALSE)
or so to avoid having these 2 functions with basically the same name, but different behavior.
I was referring to functions within the |
In the end I did not need that function now, so I will close this merge request. I might open it again should I actually need it. |
Good to know. But |
is_quitte()
tests the minimal quitte "standard", that is:data.frame
class andmodel
,scenario
,region
,variable
,unit
,period
, andvalue
columns.