-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speed-up read.snapshot #101
Conversation
orichters
commented
Oct 8, 2024
- using data.table::fread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Oliver! Time improvements look very promising. I have made no separate tests, but will be happy to check performance once it is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need to include a new dependency for that.
t <- Sys.time(); d <- read.quitte("/p/projects/remind/users/oliverr/data/NGFS5-S14_2024-07-18-snapshot_R5.csv", check.duplicates = FALSE, drop.na = TRUE); print(Sys.time() - t)
Time difference of 2.771989 secs
I wasn't aware that the duplicate check was so time-consuming. Still, reading larger snapshots, this setup seems to be much faster
|
Pretty much a constant factor (if you use all the relevant arguments). |
Ok, hope that is sufficiently fast for the scenario mip people. Thanks for your intervention. |