edgeTransport 2.0 release #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GETrefactoring
…GETrefactoring
…GETrefactoring
…GETrefactoring
…nto EDGETrefactoring
…GETrefactoring
…nto EDGETrefactoring
…GETrefactoring
…GETrefactoring
…GETrefactoring
…GETrefactoring
Supply all necessary scenarios
johannah-pik
commented
Jul 18, 2024
This was referenced Jul 18, 2024
jmuessel
approved these changes
Jul 18, 2024
| @@ -16,36 +18,32 @@ fullREMIND <- function() { | |||
| rem_years <- seq(2005, 2150, 5) | |||
| rem_years_hist <- seq(1990, 2150, 5) | |||
|
|
|||
| # Enable madrat caching for edgeTransport | |||
| madrat::madratAttach("edgeTransport") | |||
| madratAttach("edgeTransport") # enable madrat caching for edgeTransport | |||
There was a problem hiding this comment.
please add madrat::: @fbenke-pik do you agree?
fbenke-pik
reviewed
Jul 19, 2024
| @@ -135,22 +134,6 @@ fullREMIND <- function() { | |||
| calcOutput("CCScapacity", subtype = "projections", round = 8, file = "pm_boundCapCCS.cs4r") | |||
| calcOutput("CCSbounds", round = 8, file = "p_boundCapCCSindicator.cs4r") | |||
| calcOutput("LimitCCS", round = 8, file = "pm_dataccs.cs3r") | |||
| calcOutput('Industry_CCS_limits', | |||
There was a problem hiding this comment.
Was this deleted intentionally? @jmuessel
There was a problem hiding this comment.
No, I'll prepare a PR rn
fbenke-pik
reviewed
Jul 19, 2024
| system(paste0('sed -i "/dummy/d" ', getConfig()$outputfolder, "/p37_clinker-to-cement-ratio.cs3r")) | ||
|
|
||
| calcOutput("Capacity", subtype = "capacityByTech", round = 6, file = "p_histCap.cs3r") # will be deleted after the merge of REMIND-EU |
There was a problem hiding this comment.
Was this brought back intentionally? @jmuessel
There was a problem hiding this comment.
I think we needed this for pCap variables later. I would leave this in for now. But I noted it to check again in some weeks, when we do sth on pCap variables.
There was a problem hiding this comment.
why can't you use the file pm_histCap.cs3r? (see below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the edgeTransport 2.0 release and merged together with the following PRs:
mrtransport #13
edgeTransport #266
reporttransport #18
remind #1749
remind2 #642
piamInterfaces #331