-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side-by-side plot of user selected variables across scenarios #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the man page for your newly created function as well.
Currently, using the
This gives the error
|
Try calling Also please note that the data as provided by Oliver cannot directly be fed into
|
Ok, so please enhance the description of the |
R/plotPercentiles.R
Outdated
@@ -0,0 +1,108 @@ | |||
#' Comparison plots show 50th percentile of user selected variables as obtained from different scenario runs. If | |||
#' available in the data, ribbon plots will also show the 33th - 67th percentile in a darker color and the 5th – 95th |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you write "if available" (as in: optional), below you say "must be given" (as in: mandatory). Can you clarify?
R/plotPercentiles.R
Outdated
|
||
#' @author Tonn Rueter | ||
#' @param df `quitte` style data frame containing all variables for each scenario. In the quitte data frame all | ||
#' percentiles must be given as individual variables. Manipulate input data frame such that all percentiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" In the quitte data frame all percentiles must be given as individual variables ..."
Please add an example to avoid misunderstandings.
"Manipulate input data frame ....."
This should not be here, as it is code documentation, but not a specification of the input parameter and therefore nothing a user has to worry about, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks great, thank you! Now, we have to wait for @orichters approval to be sure that the function works as intended by him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I looked at the examples and they look really good, as I hoped for. We could now add that to the climate section of compareScenarios2 (conditional on data availability)? I did not check the code, but trust Falk's assessment here
I think this needs to be merged first? remindmodel/remind#1475
The code is fine, but some decisions concerning the expected format of the input parameters are debatable (as in: there is no right or wrong given the data we have right now). We probably have to revisit this point once we have a run with actual data. |
Function generates a facet wrap/grid plot that shows user defined variables side by side for comparison across different scenarios. Solves Improve cs2 climate plots issue. Plot examples can be found in here