Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added filter argument in visualizeDependencies #176

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

tscheypidi
Copy link
Member

No description provided.

@tscheypidi tscheypidi requested a review from deleip July 21, 2023 09:55
Copy link
Contributor

@deleip deleip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool functionality, thanks for adding! Just one small comment in the parameter description

@@ -2,25 +2,26 @@
#'
#' Creates a graphical visualization of dependencies between functions in the mr-universe.
#'
#' @param functions function or vector of functions to be analyzed
#' @param ... function or vector of functions to be analyzed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can also be multiple arguments now, right? Then it should be "functions or vector of functions to be analyzed" I would say. Or "function(s)"

R/visualizeDependencies.R Outdated Show resolved Hide resolved
@tscheypidi tscheypidi merged commit 9e56022 into pik-piam:master Jul 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants