Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GH-15937: stream timeout option overflow. #15942

Closed
wants to merge 3 commits into from
Closed

Fix GH-15937: stream timeout option overflow. #15942

wants to merge 3 commits into from

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen devnexen marked this pull request as draft September 17, 2024 18:45
@devnexen devnexen linked an issue Sep 17, 2024 that may be closed by this pull request
php_network.h integer overflow #15937
Closed
@devnexen devnexen marked this pull request as ready for review September 17, 2024 19:58
cmb69
cmb69 reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this!

main/php_network.h Outdated Show resolved Hide resolved
ext/standard/tests/streams/gh15937.phpt Outdated Show resolved Hide resolved
cmb69
cmb69 reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except for the nits regarding the test case.

ext/standard/tests/streams/gh15937.phpt Show resolved Hide resolved
ext/standard/tests/streams/gh15937.phpt Outdated Show resolved Hide resolved
@cmb69 cmb69 removed the ABI break label Sep 30, 2024
@devnexen devnexen closed this in 332b067 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

php_network.h integer overflow
2 participants
@devnexen @cmb69