Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Windows install and configuration section #3795

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Sep 25, 2024

A big open question is whether we should pull the build instructions in from the Wiki.

Probably needs more markup/whitespace/wording cleanups, but the most egregious stuff should be gone.

install/windows/iis.xml Outdated Show resolved Hide resolved
install/windows/iis.xml Outdated Show resolved Hide resolved
install/windows/iis.xml Outdated Show resolved Hide resolved
install/windows/iis.xml Outdated Show resolved Hide resolved
install/windows/tools.xml Outdated Show resolved Hide resolved
install/windows/troubleshooting.xml Outdated Show resolved Hide resolved
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final comment/suggestion, but LGTM otherwise.

Thank you!

install/windows/index.xml Show resolved Hide resolved
@jimwins jimwins merged commit 2dbf3d9 into php:master Sep 30, 2024
2 checks passed
@jimwins jimwins deleted the rework-install-windows branch September 30, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants