Add caution about openssl_pkey_derive key_length parameter #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
openssl_pkey_derive_key_length_caution
branch
from
a37bf70
to
e72db2e
Compare
cmb69
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Thank you!
I agree that it's probably good to deprecated this parameter.
I also think that we should add acronym definitions for ECDH and DH, but that can be done in a separate PR.
|
I created the 8.5 mass deprecation RFC with a stub for the deprecation: https://wiki.php.net/rfc/deprecations_php_8_5 Feel free to fill it out. :) |
Co-authored-by: Christoph M. Becker <[email protected]>
Thanks
Add some description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably deprecate that
key_lengthin 8.5...