Fix and update docs for openssl_csr_new #3787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
openssl_csr_new_update
branch
from
2bbc552
to
28be1a2
Compare
cmb69
approved these changes
Sep 28, 2024
Comment on lines
+154
to
+157
| configuration options for the <acronym>CSR</acronym>. Both | ||
| <parameter>distinguished_names</parameter> and | ||
| <parameter>extra_attributes</parameter> are associative arrays, whose keys | ||
| are converted to OIDs and applied to the relevant part of the request. |
There was a problem hiding this comment.
There appear to have been no changes except line wrapping. Consider to leave at is was (somewhat easier for translators):
Suggested change
| configuration options for the <acronym>CSR</acronym>. Both | |
| <parameter>distinguished_names</parameter> and | |
| <parameter>extra_attributes</parameter> are associative arrays, whose keys | |
| are converted to OIDs and applied to the relevant part of the request. | |
| configuration options for the <acronym>CSR</acronym>. Both <parameter>distinguished_names</parameter> and | |
| <parameter>extra_attributes</parameter> are associative arrays whose keys are | |
| converted to OIDs and applied to the relevant part of the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been many mistakes and the docs did not much the implementation. This fixes it.