Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpm/configuration.xml Clarify the option descriptions #3772

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mmalferov
Copy link
Member

Maybe we should explain the access log format in more detail?

Maybe we should explain the access log format in more detail?
@mmalferov mmalferov changed the title configuration.xml Clarify the option descriptoins fpm/configuration.xml Clarify the option descriptoins Sep 23, 2024
@mmalferov mmalferov changed the title fpm/configuration.xml Clarify the option descriptoins fpm/configuration.xml Clarify the option descriptions Sep 23, 2024
@Girgias
Copy link
Member

Girgias commented Sep 23, 2024

Possibly? But I don't know much about it as @bukka maintains FPM

Copy link
Member

@jimwins jimwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor notes, but LGTM otherwise.

install/fpm/configuration.xml Outdated Show resolved Hide resolved
install/fpm/configuration.xml Outdated Show resolved Hide resolved
install/fpm/configuration.xml Outdated Show resolved Hide resolved
install/fpm/configuration.xml Outdated Show resolved Hide resolved
install/fpm/configuration.xml Outdated Show resolved Hide resolved
mmalferov and others added 5 commits September 24, 2024 01:55
Add required replaceable name

Co-authored-by: Jim Winstead <[email protected]>
Add required replaceable name

Co-authored-by: Jim Winstead <[email protected]>
Amend typo

Co-authored-by: Jim Winstead <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants