get-debug-type.xml Make the example executable + tags #3755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Sep 22, 2024
Comment on lines
168
to
172
| echo get_debug_type(new class implements A {}) . PHP_EOL | ||
| , get_debug_type(new class implements A,B {}) . PHP_EOL | ||
| , get_debug_type(new class extends C {}) . PHP_EOL | ||
| , get_debug_type(new class extends C implements A {}) . PHP_EOL | ||
| ; |
There was a problem hiding this comment.
The indent here seems to be slightly off
There was a problem hiding this comment.
I think I would leave that as is; the leading commas are somwhat uncommon, and someone reading it, might suggest to change it again (we really should have a CS for the examples in the manual).
Maybe change the dots to commas, though.
There was a problem hiding this comment.
No there was an actual issue with the indent which was mixing tabs and spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.