Fix type juggling notes for list() and array destructuring #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update notes about the handling of missing keys and non-arrays during array destructuring to match the behavior seen on 3v4l.org, which doesn't issue a warning or notice in some cases where the documentation claims it does. Also update list() docs to provide the same information. list(): * missing key: https://3v4l.org/bYBt6 * destructuring an integer: https://3v4l.org/7lNhK * a boolean: https://3v4l.org/p5LDd * a string: https://3v4l.org/KHSAH * null: https://3v4l.org/lk1iu array notation: * missing key: https://3v4l.org/KCiTC * destructuring an integer: https://3v4l.org/louVG * a boolean: https://3v4l.org/SWL5L * a string: https://3v4l.org/aK90L * null: https://3v4l.org/Y8cOY Fixes php#3640.
MatmaRex
reviewed
Aug 31, 2024
| Array dereferencing a scalar value which is not a <type>string</type> | ||
| yields &null;. Prior to PHP 7.4.0, that did not issue an error message. | ||
| As of PHP 7.4.0, this issues <constant>E_NOTICE</constant>; | ||
| as of PHP 8.0.0, this issues <constant>E_WARNING</constant>. |
There was a problem hiding this comment.
This was about array dereferencing ($a = 42; $a[0]) not destructuring ([$a] = 42;), and I think it was correct. Only destructuring weirdly yields null with no warning.
MatmaRex
reviewed
Aug 31, 2024
| </note> | ||
| <note> | ||
| <para> | ||
| Attempting to access element of a scalar value yields &null;. |
There was a problem hiding this comment.
I would say: "Attempting to unpack a scalar value assigns null to all variables." to be consistent with the existing wording.
There's also already a note above: "Strings can not be unpacked" which should probably say "Only arrays and objects that implement ArrayAccess can be unpacked".
And an example below, where the comment could be clarified:
// list() doesn't work with strings
list($bar) = "abcde";
var_dump($bar); // NULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update notes about the handling of missing keys and non-arrays during array destructuring to match the behavior seen on 3v4l.org, which doesn't issue a warning or notice in some cases where the documentation claims it does. Also update list() docs to provide the same information.
list():
array notation:
Fixes #3640.