-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert MongoDB documentation from a top element of set to book #3627
base: master
Are you sure you want to change the base?
Conversation
30cee85
to
4469436
Compare
This PR is now ready for review. The build failure is due to this PR only working in tandem with the accompanying |
Thank you! This appears to be a very reasonable change to me, and I think it's okay for translations to catch up with this soon (given that the required changes are kept within bounds). So, in my opinion, this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me and not that hard to update.
Convert all underlying elements as needed: - books to parts or chapters - articles to sections Move the Predefined Constants page from the Installing/Configuring section to its own Change the following xml:ids: - book.mongodb to mongodb.mongodb - set.mongodb to book.mongodb - book.bson to mongodb.bson
4469436
to
46f531d
Compare
Please advise whether we can move forward with this and the If this gets merged, I can open a PR with the same changes in some/all of the translation repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current set of changes LGTM! The build doesn't quite like it though ;) |
I think this just needs php/doc-base#138 to work. |
No objections from my end. Thanks for taking this on @haszi.
That will be a welcome improvement. |
Convert all underlying elements as needed:
<books>
to<part>
s or<chapter>
s<article>
s to<section>
sMove the Predefined Constants page from the Installing/Configuring section to its own
Change the following
xml:id
s:book.mongodb
tomongodb.mongodb
set.mongodb
tobook.mongodb
book.bson
tomongodb.bson
Please note that these changes only work when the accompanying
doc-base
changes are merged too (php/doc-base#138).Note:
Please note that because of the difference between
root chunks
andcontainer chunks
inPhD
(ie. a<book>
and a<part>
), the four pages linked to from the main MongoDB page (MongoDB, BSON, Monitoring and Exceptions) are only going to list their underlying classes without listing each method of each class.E.g. the MongoDB Extension Classes page will only list the 19 classes belonging to that group of classes instead of listing the 19 classes plus all their 144 methods. As before, the methods are still listed on the pages of their respective classes.