Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl-init.xml: replace 'resource' to 'session' #3623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions reference/curl/functions/curl-init.xml
Original file line number Diff line number Diff line change
Expand Up @@ -89,18 +89,20 @@
<programlisting role="php">
<![CDATA[
<?php
// create a new cURL resource

// Create a new cURL session
$ch = curl_init();

// set URL and other appropriate options
// Set URL and other appropriate options
curl_setopt($ch, CURLOPT_URL, "http://www.example.com/");
curl_setopt($ch, CURLOPT_HEADER, 0);

// grab URL and pass it to the browser
// Grab URL and pass it to the browser
curl_exec($ch);

// close cURL resource, and free up system resources
// Close cURL session, and free up system resources
curl_close($ch);
Comment on lines -102 to 104
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new comment doesn't seem to be right. The old comment would at least be correct prior to PHP 8.0.0. Not sure how to improve the comment; see also the related #3622 (comment).


?>
]]>
</programlisting>
Expand Down
Loading