Fix translation of literal code

[joshuaruesweg]

See a6a3ac0

@msamesch Is there a way to communicate with you about what things you're translating next? Was the problem currently simply not there, because you translated practically alone?

We unfortunately overlapped and I had also (started) translating the attributes. This is vexing and (hopefully) avoidable.

[msamesch]

@joshuaruesweg I'm sorry about that and I knew this would probably happen sooner or later. That's why as for that file it's perfectly fine for me to replace it with your version. What I intended to suggest (should have also done so) is that when somebody starts a new translation, the first thing to do is to push the file with the EN-Revision line and "status wip" or alternatively send an email.

[joshuaruesweg]

I hadn't finished the translation yet, so it fits for me to have your translation in it. No worries :)

I will then in the future simply open a draft PR before, which starts with the English version of the file, before I start to translate. Then the whole thing is completely obvious for everyone and probably easier than sending any emails.

[msamesch]

OK, good idea, so will I. Do you know how to do it on the commandline?

[joshuaruesweg]

Do you know how to do it on the commandline?

You mean opening Pull-Request with the commandline [1]? Or what exactly do you mean?

[1] I know, there is a command like git request-pull within git, but I have never used such a command and basically create a pull request within the web version of Github.

[msamesch]

Thanks. I'll do some RTFM. ;)

[msamesch]

Fixed with review.

[msamesch]

Fixed with review.

[msamesch]

This file was tagged as "wip" for a review. With this review I already fixed some of the above.

[joshuaruesweg]

This file was tagged as "wip" for a review. With this review I already fixed some of the above.

Thanks, yes, I had overlooked the WIP within the comment. That still takes a lot of getting used to for me, because intuitively I would work with own branches for things that aren't ready yet (and draft pull requests accordingly, if needed). If the documentation is ready, it will be merged with an Pull-Request into master. This also makes a review easier, because it is much easier to note things in PRs (if you want, I am happy to make sich reviews, too).

But yes, I'll keep in mind how you guys do it here and adapt accordingly.

Thanks for the clarification!

[msamesch]

I don't know, how others do this and probably there are better ways (e.g. the afore mentioned draft PRs). I just installed gh, the official github commandline tool. Up until now I've used git commands.

[msamesch]

Should I fix this or do uptate your PR with the latest base branch so this can be committed directly?

[joshuaruesweg]

Should I fix this or do uptate your PR with the latest base branch so this can be committed directly?

I have rebased the commit accordingly. If you want, you can merge it together with yours! :)

[msamesch]

Again thanks a lot.