Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redis redelivery_delay setting does not work #1343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: redis redelivery_delay setting does not work #1343

wants to merge 1 commit into from

Commits on Mar 18, 2024

  1. fix: redis redelivery_delay setting does not work 

    When using the redis transport, RedisConsumer::processResult() creates the redelivered record prior to the RedisSubscription callback executing. The subscription callback attached with Enqueue\Consumption\QueueConsumer then invokes RedisConsumer::reject(). Calling acknowledge() deletes the redelivered record which was created earlier. Thus, we should not create a new record in reject() and we should only call acknowledge() if we do not wish to redeliver. I have tested and confirmed that this change fixes the issue. However, if there is a better solution, please advise.

Resolves php-enqueue#1342
    @compwright
    compwright authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    68dcc77 View commit details
    Browse the repository at this point in the history