Add Mobile Filter and Change Mobile Add Resource #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to keep consistent with Desktop ChooseResourceType
Added horizontal bar to mobile filter. Reset mobile add resource modal on close.
astoppop
changed the title
gcardonag
requested changes
Aug 30, 2024
There was a problem hiding this comment.
It seems a few of our tests are failing when applied to some of these changes. I tried digging into the cause of the issues, and here are a few things to address:
- The test at
cypress/e2e/desktop/crowdsourcing.cy.jsnormally targets an element withdata-cy=button-contribute-waterelement. This code replaced it with an element that hasdata-cy=button-WATER-data-selector- I tried to update the test to replace the test targeting to use the new naming convention, but it fails because the site is rendering two elements with the same value of
data-cy=button-WATER-data-selector. This should probably be fixed since there should only be one of these rendering based on whether the site is mobile or desktop.
- I tried to update the test to replace the test targeting to use the new naming convention, but it fails because the site is rendering two elements with the same value of
gcardonag
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Change Summary
Changed mobile add resource design, along with some changes to make it more consistent with choose resource. Implemented filter for mobile.
Change Reason
Mobile add resource design didn't match Figma. Mobile filter was not implemented.
Related Issue: fixes #511