Extend SpDiffPresenter to make it navigable accross differences #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was merged |
|
This feature needs both pharo-project/pharo#11641 and #1305 |
|
I re-opened this PR |
|
So is it working because the tests are green. |
|
This is causing an issue with the wrapping: pharo-project/pharo#14640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Top, Next difference, Previous difference in SpDiffPresenter to easily navigate
pharo-project/pharo#11641 required! (because I had to change the morphic class DiffMorph)
Defult behavior of SpDiffPresenter unchanged (by default no buttons will show up)