General result shows filtered tests #84
Conversation
DurieuxPol
changed the title
|
Great! There is |
DurieuxPol
force-pushed
the
enh/resultRapport
branch
from
7bde5b6
to
e6e1ba6
Compare
There was a problem hiding this comment.
Thanks @DurieuxPol ! Could you do the renames? then for the big comment we can discuss tomorrow :)
src/MuTalk-Model/MTAnalysis.class.st
Outdated
| into: [ :accumulator :test | | ||
| accumulator add: | ||
| test -> testFilter filteredTestReason. | ||
| accumulator ] |
There was a problem hiding this comment.
Hmm this method is strange :).
- First, this inject:into: could be replaced by a
collect:(a simplemap) no? - Second, the objective of this method is to store the tests + reason, right?
I have one question here. All filtered tests have the same reason right now, right? I wonder why the test filter does not return the "tuple" already instead of creating it in here... It's the filter that decides to filter, then it could be the filter that attaches this to the test :)
There was a problem hiding this comment.
You're right, I refactored the test filters in this direction
src/MuTalk-Model/MTAnalysis.class.st
Outdated
| @@ -536,6 +563,7 @@ MTAnalysis >> generateResults [ | |||
| | tests | | |||
| mutantResults := OrderedCollection new. | |||
| tests := testFilter filterTests: testCases. | |||
| self filteredTestsFrom: (testCases copyWithoutAll: tests). | |||
There was a problem hiding this comment.
May I propose to rename tests into filteredTests? :)
| arg1 , ' ' , arg2 ]. | ||
|
|
||
| reasonString , pragmaString , '>' ] | ||
| ] |
There was a problem hiding this comment.
This method is weird... why is it attaching > at the end of the string?
There was a problem hiding this comment.
Because reasonString is the start of the string, and it contains <.
It's because I wanted the pragma to be between <>, like this <pragma>
…filtered tests" to "excluded tests" to match test filters instance variables
Also shows the reason and the code of the selected test.