Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI not working #118

Merged
merged 17 commits into from
Jun 27, 2024
Merged

CI not working #118

merged 17 commits into from
Jun 27, 2024

Conversation

matburnx
Copy link
Contributor

@matburnx matburnx commented Jun 18, 2024

Changed nodeToMutate to adapt to the different operators

Fixed an issue where the data given to the JSON exporter would be a Character instead of a String, breaking the exporter

Added expressionToReplace and newExpression to operators that needed it

Changed URL to the correct one in JsonExporterTest

The last fix where I commented lines that broke the program seems wrong, I think it would be more cautious if we replaced those lines by something that does the same job instead of just removing it

An example of a CI can be found here, it is very similar to the one already available on the repo

Added the possibility of adding a job summary in the Action that gives the basic information such as the number of tests killed, alive or terminated and the mutation score as well as the commit or the pull request ID

Modified `testWorking` URL to the correct one
Modified `run` not to have `title: was sent to nil`
Added `expressionToReplace` and `newExpression` to most classes representing operators in the mutations
Modified some `expressionToReplace` and `newExpression` that didn't work
Still works as intended, but may be interesting to still try to fix it instead of removing it
Removed all the useless `expressionToReplace` and `newExpression` methods
Added `MTCIMarkdownExporter`, for now it is non usable
Added a simple test to it
`Microdown` could be more used to have a better formatting of the content in the file
Using `Microdown` could help us a lot for this issue
First try to manage issues with table format of Markdown
Changed `uninstallMetalinks` to uninstall only if necessary
@matburnx
Copy link
Contributor Author

The last fix where I commented lines that broke the program seems wrong, I think it would be more cautious if we replaced those lines by something that does the same job instead of just removing it

It is now fixed as explained here

this one too...

The other weird line is fixed here

@guillep
Copy link
Contributor

guillep commented Jun 27, 2024

Only two tests are failing!

imagen

@matburnx
Copy link
Contributor Author

For MTCIMarkdownExporterTest, SmallBank is needed.
We could skip it like the JSON exporter test.
I added a fix for the other failing test.

@guillep
Copy link
Contributor

guillep commented Jun 27, 2024

For MTCIMarkdownExporterTest, SmallBank is needed. We could skip it like the JSON exporter test. I added a fix for the other failing test.

ok! let's talk quickly about this

@guillep
Copy link
Contributor

guillep commented Jun 27, 2024

Now the Json exporter is failing

MTCITonelJsonExporterTest
 ✗ #testWorking (115ms)
FileDoesNotExistException: '/home/runner/.smalltalkCI/_builds/pharo-local/iceberg/pharo-contributions/mutalk/src/MuTalk-CI-Tests/MTSmallBank.class.st'
File>>openForWrite:
File>>openForRead
File>>readStream
FileHandle>>binaryReadStream
FileSystem>>binaryReadStreamOn:
FileReference>>binaryReadStream
FileReference(AbstractFileReference)>>readStreamEncoded:
FileReference>>readStream
FileReference(AbstractFileReference)>>readStreamDo:
MTCITonelJsonExporter>>getHashOfFile:
MTCITonelJsonExporter>>exportClassMutations:
[ :class | 
		                self exportClassMutations: class ] in MTCITonelJsonExporter>>export
Array(SequenceableCollection)>>collect:
MTCITonelJsonExporter>>export
MTCITonelJsonExporterTest>>testWorking ...export
MTCITonelJsonExporterTest(TestCase)>>performTest

We are getting close!

Skip test that has a lots of strong dependencies
@guillep
Copy link
Contributor

guillep commented Jun 27, 2024

Nice! Now, Microdown is not available in Pharo 9.
I'll open an issue for that.

@guillep guillep merged commit fa2f9fe into pharo-contributions:master Jun 27, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants