Cleanup: use #isNotNil instead of #notNil

Fix #27

src/XML-Parser-Tests-Conformance/XMLConformanceTest.class.st

@@ -439,7 +439,7 @@ XMLConformanceTest >> ignorableParserExceptions [
 
 { #category : #testing }
 XMLConformanceTest >> isIgnorableParserException: anError [
-	^ self ignorableParserExceptions notNil
+	^ self ignorableParserExceptions isNotNil
 		and: [self ignorableParserExceptions handles: anError]
 ]
 

src/XML-Parser-Tests-Conformance/XMLConformanceVirtualFileExternalEntityResolver.class.st

@@ -47,7 +47,7 @@ XMLConformanceVirtualFileExternalEntityResolver >> resolveExternalEntityURI: anX
 				withSelector: sourceSelector].
 
 	contents := self virtualFileClass perform: sourceSelector.
-	(aMaxSize notNil
+	(aMaxSize isNotNil
 		and: [contents size > aMaxSize])
 		ifTrue: [
 			self

src/XML-Parser-Tests/XMLDFALimitsTest.class.st

@@ -30,7 +30,7 @@ XMLDFALimitsTest >> testDFAStateCacheLimit [
 		visitedStates add: currentState.
 		previousState := currentState.
 		currentState := currentState nextDFAStateMatching: name.
-		self assert: currentState notNil.
+		self assert: currentState isNotNil.
 		i = names size
 			ifTrue: [
 				visitedStates do: [:each |

src/XML-Parser-Tests/XMLDOMParserTest.class.st

@@ -83,8 +83,8 @@ XMLDOMParserTest >> testAttributeNamespaces [
 			assert:
 				(each attributeNames allSatisfy: [:name |
 					(each attributeNodeAt: name namespaceURI: 'defaultNS') isNil]);
-			assert: (each attributeNodeAt: 'ps:family-name' namespaceURI: 'personNS') notNil;
-			assert: (each attributeNodeAt: 'ps:first-name' namespaceURI: 'personNS') notNil]
+			assert: (each attributeNodeAt: 'ps:family-name' namespaceURI: 'personNS') isNotNil;
+			assert: (each attributeNodeAt: 'ps:first-name' namespaceURI: 'personNS') isNotNil]
 ]
 
 { #category : #tests }

src/XML-Parser-Tests/XMLExceptionTest.class.st

@@ -123,7 +123,7 @@ XMLExceptionTest >> testFormatSignalWith [
 			on: Error
 			do: [ :exception | raisedException := exception ].
 		self
-			assert: raisedException notNil;
+			assert: raisedException isNotNil;
 			assert: raisedException class identicalTo: self exceptionClass;
 			assert: raisedException messageText equals: '1' ]
 ]
@@ -140,7 +140,7 @@ XMLExceptionTest >> testFormatSignalWithArguments [
 			on: Error
 			do: [ :exception | raisedException := exception ].
 		self
-			assert: raisedException notNil;
+			assert: raisedException isNotNil;
 			assert: raisedException class identicalTo: self exceptionClass;
 			assert: raisedException messageText equals: '1 two 3 four' ]
 ]
@@ -154,7 +154,7 @@ XMLExceptionTest >> testFormatSignalWithWith [
 			on: Error
 			do: [ :exception | raisedException := exception ].
 		self
-			assert: raisedException notNil;
+			assert: raisedException isNotNil;
 			assert: raisedException class identicalTo: self exceptionClass;
 			assert: raisedException messageText equals: '1 two' ]
 ]
@@ -173,7 +173,7 @@ XMLExceptionTest >> testFormatSignalWithWithWith [
 			on: Error
 			do: [ :exception | raisedException := exception ].
 		self
-			assert: raisedException notNil;
+			assert: raisedException isNotNil;
 			assert: raisedException class identicalTo: self exceptionClass;
 			assert: raisedException messageText equals: '1 two 3' ]
 ]
@@ -193,7 +193,7 @@ XMLExceptionTest >> testFormatSignalWithWithWithWith [
 			on: Error
 			do: [ :exception | raisedException := exception ].
 		self
-			assert: raisedException notNil;
+			assert: raisedException isNotNil;
 			assert: raisedException class identicalTo: self exceptionClass;
 			assert: raisedException messageText equals: '1 two 3 four' ]
 ]
@@ -224,7 +224,7 @@ XMLExceptionTest >> testSignalMessageFrom [
 			on: Error
 			do: [ :exception | raisedException := exception ].
 		self
-			assert: raisedException notNil;
+			assert: raisedException isNotNil;
 			assert: raisedException class identicalTo: self exceptionClass;
 			assert: raisedException messageText equals: ('({1}) {2}' format:
 						 (Array

src/XML-Parser-Tests/XMLHTTPRequestTest.class.st

@@ -93,7 +93,7 @@ XMLHTTPRequestTest >> testEnableCompression [
 	request acceptEncoding do: [ :each |
 		self assert:
 			(XMLHTTPDecompressingReadStreamAdapterFactory classForCompression:
-				 each) notNil ]
+				 each) isNotNil ]
 ]
 
 { #category : #tests }

src/XML-Parser-Tests/XMLIntegerReaderTest.class.st

@@ -132,7 +132,7 @@ XMLIntegerReaderTest >> testNonDigit [
 					 uppercaseLetterInterval includes: each ] ])
 				ifTrue: [
 					self
-						assert: (reader nextIntegerWithBase: base) notNil;
+						assert: (reader nextIntegerWithBase: base) isNotNil;
 						assert: reader atEnd ]
 				ifFalse: [
 					self

src/XML-Parser-Tests/XMLNodeWithChildrenTest.class.st

@@ -263,7 +263,7 @@ XMLNodeWithChildrenTest >> testAllNodesDetect [
 	allNodes := nodeWithNodes allNodes.
 	detectedNode := nodeWithNodes allNodesDetect: [ :each | each isPI ].
 	self
-		assert: detectedNode notNil;
+		assert: detectedNode isNotNil;
 		assert: detectedNode isPI;
 		assert: detectedNode
 		equals: (allNodes detect: [ :each | each isPI ]);
@@ -460,7 +460,7 @@ XMLNodeWithChildrenTest >> testDescendantNodesDetect [
 	detectedNode := nodeWithNodes descendantNodesDetect: [ :each |
 		                each isPI ].
 	self
-		assert: detectedNode notNil;
+		assert: detectedNode isNotNil;
 		assert: detectedNode isPI;
 		assert: detectedNode
 		equals: (descendantNodes detect: [ :each | each isPI ]);
@@ -728,7 +728,7 @@ XMLNodeWithChildrenTest >> testNodesDetect [
 	node := self newNodeWithNodes.
 	detectedNode := node nodesDetect: [ :each | each isComment ].
 	self
-		assert: detectedNode notNil;
+		assert: detectedNode isNotNil;
 		assert: detectedNode
 		equals: (node nodes detect: [ :each | each isComment ]);
 		assert:

src/XML-Parser-Tests/XMLNodeWithElementsTest.class.st

@@ -522,7 +522,7 @@ XMLNodeWithElementsTest >> testAllElementsDetect [
 	detectedElement := nodeWithElements allElementsDetect: [ :each |
 		                   each isNamed: 'prefix:four' ].
 	self
-		assert: detectedElement notNil;
+		assert: detectedElement isNotNil;
 		assert: (detectedElement isNamed: 'prefix:four');
 		assert: detectedElement
 		equals:
@@ -827,7 +827,7 @@ XMLNodeWithElementsTest >> testDescendantElementsDetect [
 	detectedElement := nodeWithElements descendantElementsDetect: [ :each |
 		                   each isNamed: 'prefix:four' ].
 	self
-		assert: detectedElement notNil;
+		assert: detectedElement isNotNil;
 		assert: (detectedElement isNamed: 'prefix:four');
 		assert: detectedElement
 		equals:
@@ -1152,8 +1152,8 @@ XMLNodeWithElementsTest >> testElementRenamingToNext [
 		usesNamespaces: false;
 		allElementsDo: [ :each |
 			| parent oldName oldLocalName nextElement |
-			((parent := each parent) notNil and: [
-					 (nextElement := each nextElement) notNil ]) ifTrue: [
+			((parent := each parent) isNotNil and: [
+					 (nextElement := each nextElement) isNotNil ]) ifTrue: [
 					oldName := each name.
 					oldLocalName := each localName.
 
@@ -1180,8 +1180,8 @@ XMLNodeWithElementsTest >> testElementRenamingToPrevious [
 		usesNamespaces: false;
 		allElementsDo: [ :each |
 			| parent oldName oldLocalName previousElement |
-			((parent := each parent) notNil and: [
-					 (previousElement := each previousElement) notNil ]) ifTrue: [
+			((parent := each parent) isNotNil and: [
+					 (previousElement := each previousElement) isNotNil ]) ifTrue: [
 					oldName := each name.
 					oldLocalName := each localName.
 
@@ -1453,7 +1453,7 @@ XMLNodeWithElementsTest >> testFindElementNamed [
 	allElements := nodeWithElements allElements.
 	foundElement := nodeWithElements findElementNamed: 'four'.
 	self
-		assert: foundElement notNil;
+		assert: foundElement isNotNil;
 		assert: (foundElement isNamed: 'four');
 		assert: foundElement
 		identicalTo: (allElements detect: [ :each | each isNamed: 'four' ]);
@@ -1472,7 +1472,7 @@ XMLNodeWithElementsTest >> testFindElementNamedNamespaceURI [
 		                findElementNamed: 'four'
 		                namespaceURI: 'testNS'.
 	self
-		assert: foundElement notNil;
+		assert: foundElement isNotNil;
 		assert: (foundElement isNamed: 'four').
 	self
 		assert: foundElement
@@ -1498,7 +1498,7 @@ XMLNodeWithElementsTest >> testFindElementNamedNamespaceURIWith [
 		                namespaceURI: 'testNS'
 		                with: [ :each | each hasChildren ].
 	self
-		assert: foundElement notNil;
+		assert: foundElement isNotNil;
 		assert: (foundElement isNamed: 'prefix:four').
 	self
 		assert: foundElement
@@ -1527,7 +1527,7 @@ XMLNodeWithElementsTest >> testFindElementNamedWith [
 		                findElementNamed: 'four'
 		                with: [ :each | each hasChildren ].
 	self
-		assert: foundElement notNil;
+		assert: foundElement isNotNil;
 		assert: (foundElement isNamed: 'four').
 	self
 		assert: foundElement

src/XML-Parser-Tests/XMLObservableListTest.class.st

@@ -79,7 +79,7 @@ XMLObservableListTest >> assertList: aList receivedNotificationOfReplacing: anOl
 XMLObservableListTest >> assertNotification: aNotification for: anObject withList: aList hasType: aSelectorCollection [
 
 	self
-		assert: aNotification notNil;
+		assert: aNotification isNotNil;
 		assert: (aSelectorCollection includes: aNotification selector).
 	self
 		assert: aNotification arguments
@@ -91,7 +91,7 @@ XMLObservableListTest >> assertNotification: aNotification for: anObject withLis
 { #category : #assertions }
 XMLObservableListTest >> denyList: aFirstList sharesObserverWith: aSecondList [
 	self deny:
-		(aFirstList observer notNil
+		(aFirstList observer isNotNil
 			and: [aFirstList observer == aSecondList observer])
 ]
 

src/XML-Parser/DTDDoctypeDefinition.class.st

@@ -335,15 +335,15 @@ DTDDoctypeDefinition >> hasAttributeValidators [
 DTDDoctypeDefinition >> hasElementIDReferences [
 	"direct access to avoid lazy initialization"
 
-	^ elementIDValidator notNil
+	^ elementIDValidator isNotNil
 		and: [elementIDValidator hasIDReferences]
 ]
 
 { #category : #testing }
 DTDDoctypeDefinition >> hasElementIDs [
 	"direct access to avoid lazy initialization"
 
-	^ elementIDValidator notNil
+	^ elementIDValidator isNotNil
 		and: [elementIDValidator hasIDs]
 ]
 
@@ -368,7 +368,7 @@ DTDDoctypeDefinition >> hasEntities [
 DTDDoctypeDefinition >> hasGeneralEntities [
 	"direct access to avoid lazy initialization"
 
-	^ generalEntities notNil
+	^ generalEntities isNotNil
 		and: [generalEntities isNotEmpty]
 ]
 
@@ -383,27 +383,27 @@ DTDDoctypeDefinition >> hasNotationAttributeValidators [
 DTDDoctypeDefinition >> hasNotations [
 	"direct access to avoid lazy initialization"
 
-	^ notations notNil and: [ notations isNotEmpty ]
+	^ notations isNotNil and: [ notations isNotEmpty ]
 ]
 
 { #category : #testing }
 DTDDoctypeDefinition >> hasParameterEntities [
 	"direct access to avoid lazy initialization"
 
-	^ parameterEntities notNil and: [ parameterEntities isNotEmpty ]
+	^ parameterEntities isNotNil and: [ parameterEntities isNotEmpty ]
 ]
 
 { #category : #testing }
 DTDDoctypeDefinition >> hasRoot [
 
-	^ root notNil and: [ root isNotEmpty ]
+	^ root isNotNil and: [ root isNotEmpty ]
 ]
 
 { #category : #testing }
 DTDDoctypeDefinition >> hasUnparsedEntities [
 	"direct access to avoid lazy initialization"
 
-	^ unparsedEntities notNil and: [ unparsedEntities isNotEmpty ]
+	^ unparsedEntities isNotNil and: [ unparsedEntities isNotEmpty ]
 ]
 
 { #category : #'instance creation' }

src/XML-Parser/DTDExternalEntityResolverLimitingDecorator.class.st

@@ -27,7 +27,7 @@ DTDExternalEntityResolverLimitingDecorator >> checkExternalEntityLimit [
 
 	| maxExternalEntities |
 
-	((maxExternalEntities := self externalEntityResolver maxExternalEntities) notNil
+	((maxExternalEntities := self externalEntityResolver maxExternalEntities) isNotNil
 		and: [self totalResolvedExternalEntities >= maxExternalEntities])
 		ifTrue: [self errorExternalEntityLimitExceeded]
 ]

src/XML-Parser/DTDExternalParsedEntity.class.st

@@ -34,7 +34,7 @@ DTDExternalParsedEntity >> hasReplacement [
 { #category : #testing }
 DTDExternalParsedEntity >> hasUnresolvedReplacement [
 
-	^ self unresolvedReplacement notNil
+	^ self unresolvedReplacement isNotNil
 ]
 
 { #category : #testing }

src/XML-Parser/DTDStaticExternalEntityResolver.class.st

@@ -133,7 +133,7 @@ DTDStaticExternalEntityResolver >> resolveExternalEntityURI: anXMLURIOrURIString
 			ifAbsent: [
 				self errorUnresolvableExternalEntityURI: anXMLURIOrURIString].
 
-	(aMaxSize notNil
+	(aMaxSize isNotNil
 		and: [replacement size > aMaxSize])
 		ifTrue: [
 			self

src/XML-Parser/DTDSubsetParserDriver.class.st

@@ -97,7 +97,7 @@ DTDSubsetParserDriver >> handleAttributeDeclaration: anElement name: anAttribute
 					defaultValue: aDefaultValue].
 
 	(self isValidating
-		and: [newAttributeValidator notNil])
+		and: [newAttributeValidator isNotNil])
 		ifTrue: [newAttributeValidator validateAttributeDeclaration].
 ]
 

src/XML-Parser/XMLAbstractFactory.class.st

@@ -33,7 +33,7 @@ XMLAbstractFactory class >> findSupportedImplementation [
 			self isSupportedImplementation
 				ifTrue: [^ self].
 
-			(self preferredImplementation notNil
+			(self preferredImplementation isNotNil
 				and: [self preferredImplementation isSupportedImplementation])
 				ifTrue: [^ self preferredImplementation].
 			self allSubclassesDo: [:each |
@@ -45,7 +45,7 @@ XMLAbstractFactory class >> findSupportedImplementation [
 
 { #category : #testing }
 XMLAbstractFactory class >> hasSupportedImplementation [
-	^ self findSupportedImplementation notNil
+	^ self findSupportedImplementation isNotNil
 ]
 
 { #category : #accessing }

src/XML-Parser/XMLCachingNodeList.class.st

@@ -254,7 +254,7 @@ XMLCachingNodeList >> firstElement [
 
 { #category : #testing }
 XMLCachingNodeList >> hasElements [
-	^ cachedElements notNil and: [cachedElements isNotEmpty]
+	^ cachedElements isNotNil and: [cachedElements isNotEmpty]
 ]
 
 { #category : #testing }

src/XML-Parser/XMLDocument.class.st

@@ -83,12 +83,12 @@ XMLDocument >> errorCannotHaveNonElementRoot [
 
 { #category : #testing }
 XMLDocument >> hasDoctypeDeclaration [
-	^ self doctypeDeclaration notNil
+	^ self doctypeDeclaration isNotNil
 ]
 
 { #category : #testing }
 XMLDocument >> hasDoctypeDefinition [
-	^ self doctypeDefinition notNil
+	^ self doctypeDefinition isNotNil
 ]
 
 { #category : #testing }
@@ -98,7 +98,7 @@ XMLDocument >> hasEncoding [
 
 { #category : #testing }
 XMLDocument >> hasRoot [
-	^ self root notNil
+	^ self root isNotNil
 ]
 
 { #category : #private }