Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Sensitive to Susceptible in Outputs #183

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

emarinier
Copy link
Member

Address #164.

Also note this change (sensitive to susceptible in the help text), which I thought was appropriate, but may be wrong:

        report_group.add_argument('--exclude-negatives', action='store_true', dest='exclude_negatives',
                                  help='Exclude negative results (those susceptible to antimicrobials) [False].',

@emarinier emarinier added the bug Something isn't working label Jul 10, 2023
@emarinier emarinier requested a review from apetkau July 10, 2023 21:05
@emarinier emarinier self-assigned this Jul 10, 2023
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me, including the help text change.

Could you add something in CHANGELOG.md about this?

@emarinier
Copy link
Member Author

This all looks great to me, including the help text change.

Could you add something in CHANGELOG.md about this?

Updated

Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks so much.

@apetkau apetkau merged commit 41b9f67 into development Jul 21, 2023
1 check passed
@apetkau apetkau deleted the fix/susceptible branch July 21, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants