Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Plasmidfinder Blast Database "enterobacteriaceae" to "enterobacteriales" #182

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

emarinier
Copy link
Member

Fixes #169 and #177.

There's nothing automatic here though. I don't know if you wanted it automatically build the list from the downloaded database files. Let me know!

@emarinier emarinier added the bug Something isn't working label Jul 10, 2023
@emarinier emarinier requested a review from apetkau July 10, 2023 20:39
@emarinier emarinier self-assigned this Jul 10, 2023
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much Eric, this looks great.

Change request

In addition to the in-line comment, can you also update the CHANGELOG.md to what has been changed?

Description of automation

For automating the list of available database (fasta) files for PlasmidFinder, this is already implemented.

On the PlasmidFinder website (https://cge.food.dtu.dk/services/PlasmidFinder/), there are two options to select:

image

However, in the underlying fasta files, there are more than two options (https://bitbucket.org/genomicepidemiology/plasmidfinder_db/src/master/). However, these map on to two different labels Enterobacteriales and Gram Positive as defined in the config file.

This mapping is already handled by StarAMR by reading the config file in the underlying installed PlasmidFinder database:

if database_type == 'gram_positive' and 'gram_positive' not in existing_database_types:
config_df = self.get_config_table(database_dir)
self.database_names = config_df.loc[config_df["name"] == "Gram Positive", "db_prefix"].tolist()

Hence, there is no need to update this list.

staramr/blast/plasmidfinder/PlasmidfinderBlastDatabase.py Outdated Show resolved Hide resolved
@emarinier
Copy link
Member Author

Okay, I think it should be good now.

Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks so much.

@apetkau apetkau merged commit 9861f84 into development Jul 21, 2023
1 check passed
@apetkau apetkau deleted the fix/enterobacteriales branch July 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

PlasmidFinder database enterobacteriaceae no longer an option
2 participants