Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata uploader to use React Router Outlet #1464

Merged
merged 8 commits into from
Feb 8, 2023

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Feb 7, 2023

Description of changes

Updated metadata importer to use React Router Outlet.

Related issue

#1456

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • [ ] Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

@ksierks ksierks marked this pull request as ready for review February 7, 2023 16:44
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You nailed it with this :) There are two nit picky things I would like you to clean up, but besides that, great job.

@joshsadam joshsadam merged commit 301c612 into development Feb 8, 2023
@ksierks ksierks deleted the metadata-uploader-outlet branch February 9, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants