Metadata uploader base #1445
Merged
Metadata uploader base #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odifying the metadata object where twp objects are stored in memory temporarily
joshsadam
reviewed
Jan 24, 2023
src/main/webapp/resources/js/components/metadata/TargetMetadataRestriction.tsx
Show resolved
Hide resolved
joshsadam
reviewed
Jan 24, 2023
...ources/js/pages/projects/samples-metadata-import/components/SampleMetadataImportComplete.tsx
Show resolved
Hide resolved
joshsadam
reviewed
Jan 24, 2023
...rces/js/pages/projects/samples-metadata-import/components/SampleMetadataImportMapColumns.tsx
Show resolved
Hide resolved
joshsadam
reviewed
Jan 24, 2023
src/main/webapp/resources/js/pages/projects/samples-metadata-import/index.js
Outdated
Show resolved
Hide resolved
joshsadam
reviewed
Jan 24, 2023
...esources/js/pages/projects/samples-metadata-import/components/SampleMetadataImportWizard.tsx
Show resolved
Hide resolved
joshsadam
reviewed
Jan 24, 2023
src/main/webapp/resources/js/pages/projects/samples-metadata-import/redux/import-utilities.ts
Show resolved
Hide resolved
joshsadam
reviewed
Jan 24, 2023
src/main/webapp/resources/js/pages/projects/samples-metadata-import/redux/importReducer.ts
Outdated
Show resolved
Hide resolved
One quick reply, because most of these comments are around Typescript. Don't we currently have two lintors in Github actions? At this point, if my Typescript still isn't sufficient, maybe we could make them stricter so the whole team is subject to this level of scrutiny. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/webapp/resources/js/components/Buttons/AddMemberButton.tsx
Outdated
Show resolved
Hide resolved
src/main/webapp/resources/js/components/Buttons/AddMemberButton.tsx
Outdated
Show resolved
Hide resolved
deepsidhu85
requested changes
Jan 27, 2023
...ava/ca/corefacility/bioinformatics/irida/ria/web/ajax/metadata/dto/ProjectMetadataField.java
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/ria/web/ajax/dto/CreateSampleResponse.java
Outdated
Show resolved
Hide resolved
joshsadam
approved these changes
Jan 27, 2023
deepsidhu85
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Contains the following metadata uploader enhancements:
Metadata uploader validate file - #1434
Metadata uploader progress bar - #1419
Metadata uploader batch endpoints - #1408
Metadata uploader restrictions - #1383
Metadata uploader parse file - #1362
Related issue
#1302
Checklist
Things for the developer to confirm they've done before the PR should be accepted: