-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor README.md #54
Conversation
Thank you for the pull request.
Therefore, we would like to apply the 1st one. |
@t-kataym, what about my PRs with refactoring of this files step-by-step ? https://github.com/pgspider/jdbc_fdw/blob/main/README.md https://github.com/EnterpriseDB/mongo_fdw/blob/master/README.md What about merging of this PR after it will be completed other PRs? |
Thank you for your proposal. Is there standard format as Readme of FDW? Could you tell me the reason why you referred firebird_fdw as an example? |
I think no. There is only more or less detailed READMEs. For ex.
|
pgspider/jdbc_fdw#14 done. https://github.com/pgspider/pgspider_ext is an independent extension, not a foreign data wrapper, but
fdw documentation example isn't applicable to https://github.com/pgspider/pgspider_ext. Features - Install - Usage yet structured. |
pgspider/influxdb_fdw#35 done. All PR need carefully reading. |
EnterpriseDB/mysql_fdw#262 done, it seems this repository isn't very active https://github.com/EnterpriseDB/mysql_fdw/pulls. |
CartoDB/odbc_fdw#139 done |
EnterpriseDB/mongo_fdw#165 done. All PRs has been made. https://github.com/laurenz/oracle_fdw have got well-structured documentation now. I think no need refactoring just now, but it will be reason if all other PRs will merged, because README from |
Thank you for creating PRs. I will confirm the PR of sqlite_fdw. |
By https://github.com/ibarwick/firebird_fdw/blob/master/README.md example of advanced FDW documentation. Add about functions, encodings, identifiers, FDW options and types of options, refactor features, notes and limitations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed the PR. Could you confirm my comments?
Thanks to https://github.com/t-kataym (author of review) pgspider#54 (review)
Please verify if all is OK or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments. Please help me to check them.
@t-kataym, I decided to stop the changes in README.md. This PR is very complicated because I still not work with git very well. Since this time I'll save a new changes in README.md for other PR. |
@mkgrgis Thank you for your update.
It is unnecessary to squash commits to one. |
Look like this sentence is for "Contributing" in README.md ;-) |
All problems are fixed, @t-kataym |
@mkgrgis Thank you so much for your PR. I will merge it. |
Thank you for your reviews, @t-kataym ! |
@t-kataym , what about my README patches to dynamodb_fdw and influxdb_fdw ? I can parallelly improve documentation and test changes in other pull requests. |
@mkgrgis , we are sorry for no reply. I ask contact persons. |
@t-kataym , still no reaction around of https://github.com/pgspider/influxdb_fdw/pull/37/files |
We are so sorry for no response.
Yes, thank you for your contribution. |
@t-kataym , I saw there is no topic tags in pgspider repositories. I think it's bad and owners of repositories can add this tags. This tags can improve thematic github searching for a new contributors and gives some PRs. See good example of tags in https://github.com/ibarwick/firebird_fdw |
@t-kataym , what about auto RPM build during https://github.com/pgspider/sqlite_fdw/pull/39/files ? I think it will be usefully not only for for PGXN https://pgxn.org/tag/fdw/ |
@mkgrgis Thank you for your advice and notification. We will consider to set topics and confirm the PR#39. |
@t-kataym , what is the difference between https://github.com/adjust/parquet_fdw and https://github.com/pgspider/parquet_s3_fdw ? Repository from "adjust" tree look like slow-refreshed, but not deprecated. My README PR comes to adjust/parquet_fdw#64 but not to https://github.com/pgspider/parquet_s3_fdw , is it normal? Should I create PR with README to pgspider version of |
@t-kataym , look like https://github.com/pgspider/parquet_s3_fdw is completely independent fork of https://github.com/adjust/parquet_fdw and Ajust GmbH does not support initial FDW very good (see adjust/parquet_fdw#64 ). Does it means I can write a new PR directly to https://github.com/pgspider/parquet_s3_fdw ? This FDW is only with old |
By https://github.com/ibarwick/firebird_fdw/blob/master/README.md example of advanced FDW documentation