Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore server status collector #557

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Restore server status collector #557

wants to merge 7 commits into from

Commits on Sep 28, 2023

  1. Revert "PMM-10292 Remove unused collector (percona#547)" 

    This reverts commit cf4ca67.
    @trvrnrth
    trvrnrth committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a627fc7 View commit details
    Browse the repository at this point in the history

  2. Allow use of server status collector with new flag 

    This is useful when running the exporter against mongos instances where
getDiagnosticData is not available.
    @trvrnrth
    trvrnrth committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    41cbfb6 View commit details
    Browse the repository at this point in the history

  3. Exclude server status histogram metrics

    @trvrnrth
    trvrnrth committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8019ed4 View commit details
    Browse the repository at this point in the history

  4. Prevent duplicate collection and always run renaming/label logic 

    This change prevents running the replSetGetStatus or serverStatus
collectors if those data have been collected already via
getDiagnosticData.

Provide data from the replSetGetStatus and serverStatus collectors to
makeMetrics in a format such that the desired renames and label
management actions are carried out.

Note that this change is not backwards compatible for anyone running
with --collector.replicasetstatus as those metrics will now have a
prefix of mongodb_rs_ rather than just mongodb_
    @trvrnrth
    trvrnrth committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    70a3bae View commit details
    Browse the repository at this point in the history

  5. Fix test expectations

    @trvrnrth
    trvrnrth committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a226795 View commit details
    Browse the repository at this point in the history

  6. Add --collector.serverstatus to reference

    @trvrnrth
    trvrnrth committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    40a3201 View commit details
    Browse the repository at this point in the history

  7. Use measureCollectTime for server status collector

    @trvrnrth
    trvrnrth committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a93062a View commit details
    Browse the repository at this point in the history