conversion to base64 string

[b-yap]

Move implementation of
https://github.com/pendulum-chain/spacewalk/blob/7c7989875e95e1cfe3b0aeba9bb6af01d9e33e58/clients/stellar-relay-lib/src/connection/helper.rs#L39-L42

pub fn to_base64_xdr_string<T: XdrCodec>(msg: &T) -> String {
	let xdr = msg.to_base64_xdr();
	String::from_utf8(xdr.clone()).unwrap_or(format!("{:?}", xdr))
}

to this repo

Cleanup of pendulum-chain/spacewalk#545

[gianfra-t]

👍

[TorstenStueber]

Thanks @b-yap, just one question.

[TorstenStueber]

Does the or case ever happen? I think we can prove that the unwrap can never fail (something the compiler can't guarantee) because to_base64_xdr will always return an ASCII string, which is always valid utf8.

That way we should be able to safely use unrwap and we would not need to add the std::format or alloc::format dependency. Or is this bad practice?

[b-yap]

Does the or case ever happen?

True, it will not.

I have reverted std.rs file and use unwrap().
I do not think it is bad practice, as long as explained well.