Add cargo test CI workflow #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ebma
approved these changes
May 3, 2024
src/xdr/xdr_codec.rs
Outdated
Comment on lines
213
to
215
| #[cfg_attr(feature = "all-types", doc = "```")] | ||
| #[cfg_attr(not(feature = "all-types"), doc = "```ignore")] | ||
| /// use substrate_stellar_sdk::{types::Auth, parse_stellar_type}; |
There was a problem hiding this comment.
Should we add a comment here on why this is necessary? Maybe we can add the explanation as a a simple comment // here instead of a doc comment without breaking the rest?
There was a problem hiding this comment.
Did you check the generated docs whether the lines
/// // For this test, we require the usage of `Auth` which is only compiled with
/// // the `all-types` feature.
/// // We will ignore the test if the feature is not enabled.
are ignored? 🤔
There was a problem hiding this comment.
Oh okay I misunderstood what you meant, I thought ignored on compilation. Latest push should show it like this (they just need to be in the scope of the test definition)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14
Changes
all-types.testandbuildwith all features enabled.