-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove migrations #498
base: main
Are you sure you want to change the base?
remove migrations #498
Conversation
582e879
to
86dcb70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
runtime/amplitude/src/lib.rs
Outdated
// Custom storage version bump | ||
use frame_support::{ | ||
pallet_prelude::StorageVersion, | ||
traits::{GetStorageVersion, OnRuntimeUpgrade}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these imports can be removed in all runtimes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super. But let's not merge this before creating the Pendulum release for the upgrade! I think it's not yet there.
Closes #454.