Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

281 inaccuracy in approve chain extension behavior #283

Merged
merged 2 commits into from
Jul 20, 2023
Merged

281 inaccuracy in approve chain extension behavior #283

merged 2 commits into from
Jul 20, 2023

Conversation

ashneverdawn
Copy link
Contributor

Closes #281

Corrects approve behavior to set rather than increment, and makes transfer_from treat u128::MAX as infinite allowance

@ashneverdawn ashneverdawn linked an issue Jul 19, 2023 that may be closed by this pull request
Inaccuracy in Approve Chain Extension behavior #281
Closed
@ashneverdawn ashneverdawn requested a review from a team July 19, 2023 14:24
@ashneverdawn ashneverdawn changed the title correct allowance behavior 281 inaccuracy in approve chain extension behavior Jul 19, 2023
ebma
ebma reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I requested one improvement.

pallets/orml-currencies-allowance-extension/src/lib.rs Outdated Show resolved Hide resolved
@ashneverdawn ashneverdawn requested a review from ebma July 19, 2023 16:02
ebma
ebma approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, good job @ashneverdawn 👍

@ashneverdawn ashneverdawn merged commit 43f0990 into main Jul 20, 2023
2 checks passed
@ashneverdawn ashneverdawn deleted the 281-inaccuracy-in-approve-chain-extension-behavior branch July 20, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inaccuracy in Approve Chain Extension behavior
2 participants
@ashneverdawn @ebma