Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

279 update the foucoco genesis configuration to latest on chain values #282

Merged

Conversation

adelarja
Copy link
Contributor

This PR aims to update the chain_spec file so that we can start the foucoco testnet from scratch.

To update the chain_spec, we made some queries to the current chain state and saved it in this PDF file:
foucoco chain state.pdf

This PR, closes this issue.

@adelarja adelarja linked an issue Jul 18, 2023 that may be closed by this pull request
3 tasks
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving some feedback already

node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/constants/amplitude.rs Outdated Show resolved Hide resolved
node/src/constants/amplitude.rs Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/constants/amplitude.rs Outdated Show resolved Hide resolved
node/src/constants/amplitude.rs Outdated Show resolved Hide resolved
node/src/constants/amplitude.rs Outdated Show resolved Hide resolved
node/src/constants/amplitude.rs Show resolved Hide resolved
@ebma ebma self-requested a review July 19, 2023 14:13
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I just suggested some improvements.

@TorstenStueber the Spacewalk parameters should be good now but can you check that we don't miss anything important about the tokens/balances configuration?

node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/chain_spec.rs Outdated Show resolved Hide resolved
node/src/constants/amplitude.rs Outdated Show resolved Hide resolved
@ebma
Copy link
Member

ebma commented Jul 19, 2023

Ah @TorstenStueber @adelarja, would it make sense to also reset the spec_version and transaction_version back to 1? (And maybe also make this change part of this PR?)

@TorstenStueber
Copy link
Member

@ebma yes, I think it makes sense and to also make this part of this PR.

runtime/foucoco/src/lib.rs Outdated Show resolved Hide resolved
node/src/constants/amplitude.rs Outdated Show resolved Hide resolved
… chain_spec as the invulnerables (collators) for the foucoco config.
@ebma
Copy link
Member

ebma commented Jul 24, 2023

Since @TorstenStueber and I approved, I'll resolve all conversations and merge it myself this time since @adelarja does not have permission to bypass the merge requirements (and the commit signing is still not set up properly).

@ebma ebma merged commit 597053d into main Jul 24, 2023
2 checks passed
@ebma ebma deleted the 279-update-the-foucoco-genesis-configuration-to-latest-on-chain-values branch July 24, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Foucoco genesis configuration to latest on-chain values
3 participants