241 update spacewalk dependencies and configure the lp token for use with the zenlink pallet #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tId and Spacewalk assets.
deleted unnecessary dependencies.
Updated spacewalk dependencies.
…n function for stellar assets.
…token-for-use-with-the-zenlink-pallet' of github.com:pendulum-chain/pendulum into 241-update-spacewalk-dependencies-and-configure-the-lp-token-for-use-with-the-zenlink-pallet
… asset chain_id and the parachain_id are the same.
…and spacewalk asset.
adelarja
changed the title
ebma
reviewed
Jul 6, 2023
TorstenStueber
approved these changes
Jul 7, 2023
…tion, allowing us to use a discriminant of 3 for the Zenlink LP token.
|
LGTM overall. |
…ion to amplitude.
…date-spacewalk-dependencies-and-configure-the-lp-token-for-use-with-the-zenlink-pallet
Signed-off-by: adelarja <[email protected]>
ebma
approved these changes
Jul 17, 2023
Co-authored-by: Marcel Ebert <[email protected]>
Co-authored-by: Marcel Ebert <[email protected]>
Co-authored-by: Marcel Ebert <[email protected]>
ebma
approved these changes
Jul 17, 2023
ebma
deleted the
241-update-spacewalk-dependencies-and-configure-the-lp-token-for-use-with-the-zenlink-pallet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to these issues: Add ZenlinkLPToken to CurrencyId enum and Add the conversion functions between Zenlink Assets and Spacewalk Assets.
For more details about how the conversion functions work, read this and this comment.
At the beginning, the conversion functions were developed using the TryFrom trait. For that, a wrapper struct was needed because neither the TryFrom trait nor the CurrencyId enum was defined in our crate. In the end, we also needed to create a function to handle the wrapper type, so I decided to use functions to convert between Spacewalk assets and Zenlink assets.
To enhance code organization and cleanliness, the conversion functions were divided into zenlink_id_to_currency_id and currency_id_to_zenlink_id.
To ensure the code can be used across all our runtimes, it was placed in a separate file within the common directory of the runtime. The currency_id_to_zenlink_id function may not be utilized at the moment, but we can retain it in case it is needed in the future.
Additionally, some unit tests were added to verify the functionality of these functions.
If I'm not mistaken, we'll need this pull request (PR) to be merged before we can merge the current one. I made a local test by merging it into my branch, and it successfully resolved several dependency issues between Spacewalk and Pendulum.