Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iss: 1873 - Fix frame not being drawn on the timeline #1875

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

iss: 1873 - Fix frame not being drawn on the timeline #1875

wants to merge 2 commits into from

Commits on Aug 25, 2024

  1. AC-1873 - Fix frame not being drawn on the timeline 

    The reason for this is that while we keep a list of keyframes to move and paint keyframes on the timeline, a keyframe also has its own "isSelected" state. This state is backed up through undo/redo operations which the layer::getSelectedFrames is not.

The solution is to remove isSelected from Keyframe, as there should only be one truth.
    @MrStevns
    MrStevns committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f2f1c31 View commit details
    Browse the repository at this point in the history

  2. Only deselect layer if the index has changed

    @MrStevns
    MrStevns committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    f85237c View commit details
    Browse the repository at this point in the history