Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain active layer track in view #1867

Merged
merged 6 commits into from
Jul 31, 2024

Commits on Jul 24, 2024

  1. maintain current layer track in view

    automatically scroll the layer UI vertically in order to maintain the current layer visible, so that selecting layers with the Up and Down arrows doesn't end up with the active one being out of view if you have many layers.
    HeCorr committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    428ce8d View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. emit new signal in LayerManager goto methods...

    ...and listen to it in timeline.cpp instead of the old signal.
    
    this fixes an issue with the current layer scrolling implementation where clicking a barely-visible layer would move it due to the scrolling happening while the pointer was still being pressed. now clicking layers no longer triggers the scrolling, only the Up and Down arrow keys do.
    
    note that I didn't remove the original signal emission from the goto methods not to break anything else.
    HeCorr committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    662ba4f View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Revert "emit new signal in LayerManager goto methods..."

    This reverts commit 662ba4f.
    MrStevns committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    7b788a6 View commit details
    Browse the repository at this point in the history
  2. Introduce property to check if timeline is scrolled vertically

    This prevents the timeline cells from swapping layers while the scrollbar emits changes.
    MrStevns committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    8ade5bc View commit details
    Browse the repository at this point in the history
  3. Introduce timer to notify when we stop scrolling

    So we can reset the 'mScrollingVertically' properly.
    MrStevns committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    e915533 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c1cdbb2 View commit details
    Browse the repository at this point in the history