Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed Polyline path #1863

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Closed Polyline path #1863

merged 8 commits into from
Jul 24, 2024

Commits on Jul 21, 2024

  1. close Polyline path if holding Ctrl key

    @HeCorr
    HeCorr committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    40b52f8 View commit details
    Browse the repository at this point in the history

  2. move default mClosed value into the header file 

    for consistency.
    @HeCorr
    HeCorr committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    bd249b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. rename mClosed to mClosedOverride

    @HeCorr
    HeCorr committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    78d4d44 View commit details
    Browse the repository at this point in the history

  2. add Closed tool option to Polyline tool 

    it makes it so the Polyline path can be automatically closed, and the Ctrl key now temporarily inverts the behavior while held.
    @HeCorr
    HeCorr committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    327ccbc View commit details
    Browse the repository at this point in the history

  3. requested changes (Polyline closed path) 

    - `_closed` -> `closed`
- `setClosed()` -> `setClosedPath()`
- `mClosedOverride` -> `mClosedPathOverrideEnabled`
- `Closed` -> `Closed Path`
    @HeCorr
    HeCorr committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1a7401a View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. PolylineTool: save closed path state

    @MrStevns
    MrStevns committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4563e43 View commit details
    Browse the repository at this point in the history

  2. ToolOptionWidget: set closed path state based on property state 

    Otherwise the checkbox won't look correct.
    @MrStevns
    MrStevns committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e0a86b6 View commit details
    Browse the repository at this point in the history

  3. ToolOptionWidget: useClosedBox -> useClosedPathPath

    @MrStevns
    MrStevns committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    bc24084 View commit details
    Browse the repository at this point in the history